icedream
/
php-language-server
1
0
Fork 0
Code Releases Activity

Remove filterSkippedReferences, no longer relevant

pull/357/head
Rob Lourens 2017-06-07 14:24:50 -07:00
parent fc7d7f419e
commit 344a2cef31
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/Validation/ValidationTest.php
View File

@ -89,7 +89,6 @@ class ValidationTest extends TestCase
$document = new PhpDocument($filename, $fileContents, $index, $parser, $docBlockFactory, $definitionResolver); $document = new PhpDocument($filename, $fileContents, $index, $parser, $docBlockFactory, $definitionResolver);
$actualRefs = $index->getReferences(); $actualRefs = $index->getReferences();
$this->filterSkippedReferences($actualRefs);
$actualDefs = $this->getTestValuesFromDefs($document->getDefinitions()); $actualDefs = $this->getTestValuesFromDefs($document->getDefinitions());
// There's probably a more PHP-typical way to do this. Need to compare the objects parsed from json files // There's probably a more PHP-typical way to do this. Need to compare the objects parsed from json files
@ -149,29 +148,6 @@ class ValidationTest extends TestCase
return $defsForAssert; return $defsForAssert;
} }
/**
* @return void
*/
private function filterSkippedReferences(&$references)
{
$skipped = [
'false', 'true', 'null', 'FALSE', 'TRUE', 'NULL',
'__', // magic constants are treated as normal constants
'Exception', 'Error', // catch exception types missing from old definition resolver
'Trait', // use Trait references are missing from old definition resolve
'->tableAlias', '->realField', '->field', '->first_name', '->last_name', '->quoteMatch', '->idCol', '->timeCol', '->dataCol',
'pathToUri', 'uriToPath' // group function use declarations are broken in old definition resolver
];
foreach ($references as $key => $value) {
foreach ($skipped as $s) {
if (strpos($key, $s) !== false) {
unset($references[$key]);
}
}
}
}
} }
function getExpectedValuesFile($testCaseFile): string function getExpectedValuesFile($testCaseFile): string