From 344a2cef31bf3851014b9f81256fe19097785360 Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Wed, 7 Jun 2017 14:24:50 -0700 Subject: [PATCH] Remove filterSkippedReferences, no longer relevant --- tests/Validation/ValidationTest.php | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/tests/Validation/ValidationTest.php b/tests/Validation/ValidationTest.php index 361ee5c..0142fdf 100644 --- a/tests/Validation/ValidationTest.php +++ b/tests/Validation/ValidationTest.php @@ -89,7 +89,6 @@ class ValidationTest extends TestCase $document = new PhpDocument($filename, $fileContents, $index, $parser, $docBlockFactory, $definitionResolver); $actualRefs = $index->getReferences(); - $this->filterSkippedReferences($actualRefs); $actualDefs = $this->getTestValuesFromDefs($document->getDefinitions()); // There's probably a more PHP-typical way to do this. Need to compare the objects parsed from json files @@ -149,29 +148,6 @@ class ValidationTest extends TestCase return $defsForAssert; } - - /** - * @return void - */ - private function filterSkippedReferences(&$references) - { - $skipped = [ - 'false', 'true', 'null', 'FALSE', 'TRUE', 'NULL', - '__', // magic constants are treated as normal constants - 'Exception', 'Error', // catch exception types missing from old definition resolver - 'Trait', // use Trait references are missing from old definition resolve - '->tableAlias', '->realField', '->field', '->first_name', '->last_name', '->quoteMatch', '->idCol', '->timeCol', '->dataCol', - 'pathToUri', 'uriToPath' // group function use declarations are broken in old definition resolver - ]; - - foreach ($references as $key => $value) { - foreach ($skipped as $s) { - if (strpos($key, $s) !== false) { - unset($references[$key]); - } - } - } - } } function getExpectedValuesFile($testCaseFile): string