icedream
/
vscode-php-intellisense
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix: always use a TCP socket instead of STDIO 

STDIO locks up for large responses
pull/202/head
Felix Becker 2017-11-18 18:39:15 -08:00
parent a62996fe33
commit ddddf2a178
1 changed files with 18 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/extension.ts
View File

@ -62,21 +62,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
} }
const serverOptions = () => new Promise<ChildProcess | StreamInfo>((resolve, reject) => { const serverOptions = () => new Promise<ChildProcess | StreamInfo>((resolve, reject) => {
function spawnServer(...args: string[]): ChildProcess { // Use a TCP socket because of problems with blocking STDIO
// The server is implemented in PHP
args.unshift(context.asAbsolutePath(path.join('vendor', 'felixfbecker', 'language-server', 'bin', 'php-language-server.php')));
args.push('--memory-limit=' + memoryLimit);
const childProcess = spawn(executablePath, args);
childProcess.stderr.on('data', (chunk: Buffer) => {
console.error(chunk + '');
});
childProcess.stdout.on('data', (chunk: Buffer) => {
console.log(chunk + '');
});
return childProcess;
}
if (process.platform === 'win32') {
// Use a TCP socket on Windows because of blocking STDIO
const server = net.createServer(socket => { const server = net.createServer(socket => {
// 'connection' listener // 'connection' listener
console.log('PHP process connected'); console.log('PHP process connected');
@ -88,12 +74,20 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
}); });
// Listen on random port // Listen on random port
server.listen(0, '127.0.0.1', () => { server.listen(0, '127.0.0.1', () => {
spawnServer('--tcp=127.0.0.1:' + server.address().port); // The server is implemented in PHP
const childProcess = spawn(executablePath, [
context.asAbsolutePath(path.join('vendor', 'felixfbecker', 'language-server', 'bin', 'php-language-server.php')),
'--tcp=127.0.0.1:' + server.address().port,
'--memory-limit=' + memoryLimit
]);
childProcess.stderr.on('data', (chunk: Buffer) => {
console.error(chunk + '');
});
childProcess.stdout.on('data', (chunk: Buffer) => {
console.log(chunk + '');
});
return childProcess;
}); });
} else {
// Use STDIO on Linux / Mac
resolve(spawnServer());
}
}); });
// Options to control the language client // Options to control the language client