From 1ac5a8fce3bd7adc0ca1a6a4e890777ca49c8ea5 Mon Sep 17 00:00:00 2001 From: Felix Becker Date: Wed, 5 Oct 2016 10:39:53 +0200 Subject: [PATCH] Handle case where version regexp doesnt match --- src/extension.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/extension.ts b/src/extension.ts index 7150729..824d78e 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -23,7 +23,12 @@ export function activate(context: vscode.ExtensionContext) { } // Parse version and discard OS info like 7.0.8--0ubuntu0.16.04.2 - let version = stdout.toString().match(/^PHP ([^\s]+)/)[1].split('-')[0]; + const match = stdout.toString().match(/^PHP ([^\s]+)/); + if (!match) { + vscode.window.showErrorMessage('Error parsing PHP version. Please check the output of php --version'); + return; + } + let version = match[1].split('-')[0]; // Convert PHP prerelease format like 7.0.0rc1 to 7.0.0-rc1 if (!/^\d+.\d+.\d+$/.test(version)) { version = version.replace(/(\d+.\d+.\d+)/, '$1-');