At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway.
BREAKING CHANGE: removes formatting support
closes#501closes#474closes#473closes#468closes#450closes#445closes#443closes#423closes#343closes#296closes#293closes#499closes#471
The identifier doesn't need to be generated for a notification to the
client, since there's no response
Add undeclared properties to TreeAnalyzer
Fix other bugs in phpdoc
* Make Descriptors minimal
SymbolDescriptor and PackageDescriptor should only contain the minumum amount of properties needed
* Add missing use
* Fixes
* Ignore ReferenceInformation->symbol
* Exclude directories from file system search
Directories can also match the glob search pattern if their names end in ".php", which will cause a read error later since the ContentRetriever implementers are expecting files. As far as I know, the only way to fix this is to do an additional check to ensure the URI is not of a directory.
This resolves#306.
* Ensure diagnostics are cleared on file deletion
Previously, error diagnostics would not be cleared when a file was deleted while it was closed. This would result in lingering errors in the problems view that could only be cleared by reloading the language server. This fix addresses the issue by adding support for workspace/didChangeWatchedFiles and automatically clearing diagnostics for deleted files.
* add FileEvent constructor
Felix Becker
Jens Hausdorf
Tyson Andre
Vincent Klaiber
Stephan Unverwerth
John Nguyen
Ivan Bozhanov
Rob Lourens
Nicholas Narsing
Jens Hausdorf
Sara Itani
Jens Hausdorf
Talv
Matthew Brown
Trevor Bortins