icedream
/
php-language-server
1
0
Fork 0
Code Releases Activity

revert return_type test and add specific return_self test

pull/550/head
Philip Nelson 2017-12-11 20:03:40 +11:00
parent 4186d8f9ce
commit a153d71266
4 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fixtures/completion/static_method_return_self.php Normal file
View File

@ -0,0 +1,12 @@
<?php
class FooClass {
public static function staticFoo(): self {
return new FooClass();
}
public function bar() { }
}
$foo = FooClass::staticFoo();
$foo->

2
fixtures/completion/static_method_return_type.php
View File

@ -1,7 +1,7 @@
<?php
class FooClass {
public static function staticFoo(): self {
public static function staticFoo(): FooClass {
return new FooClass();
}

22
tests/Server/TextDocument/CompletionTest.php
View File

@ -620,6 +620,28 @@ class CompletionTest extends TestCase
], true), $items);
}
public function testStaticMethodReturnSelf()
{
$completionUri = pathToUri(__DIR__ . '/../../../fixtures/completion/static_method_return_self.php');
$this->loader->open($completionUri, file_get_contents($completionUri));
$items = $this->textDocument->completion(
new TextDocumentIdentifier($completionUri),
new Position(11, 6)
)->wait();
$this->assertCompletionsListSubset(new CompletionList([
new CompletionItem(
'bar',
CompletionItemKind::METHOD,
'mixed',
null,
null,
null,
null,
null
)
], true), $items);
}
private function assertCompletionsListSubset(CompletionList $subsetList, CompletionList $list)
{
foreach ($subsetList->items as $expectedItem) {

2
tests/Validation/cases/WithReturnTypehints.php.expected.json
View File

@ -69,7 +69,7 @@
},
"containerName": "Fixtures\\Prophecy\\WithReturnTypehints"
},
"type__tostring": "\\self",
"type__tostring": "\\Fixtures\\Prophecy\\WithReturnTypehints",
"type": {},
"declarationLine": "public function getSelf(): self {",
"documentation": null