From 929ea30724973cc45badd80a2b019942f8bca483 Mon Sep 17 00:00:00 2001 From: John S Long Date: Sat, 29 Apr 2017 23:11:49 -0500 Subject: [PATCH] Refactor duplicate check for package name, fix syntax violation --- src/Indexer.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Indexer.php b/src/Indexer.php index 00043cb..4558431 100644 --- a/src/Indexer.php +++ b/src/Indexer.php @@ -149,10 +149,13 @@ class Indexer $cacheKey = null; $index = null; foreach (array_merge($this->composerLock->packages, $this->composerLock->{'packages-dev'}) as $package) { + if ($package->name !== $packageName) { + continue; + } // Check if package can be cached. $packageVersion = ltrim($package->version, 'v'); // If package is anchored to a version - if ($package->name === $packageName && strpos($packageVersion, 'dev') === false) { + if (strpos($packageVersion, 'dev') === false) { $packageKey = $packageName . ':' . $packageVersion; $cacheKey = self::CACHE_VERSION . ':' . $packageKey; // Check cache @@ -160,7 +163,7 @@ class Indexer break; // If package is checked out - } elseif ($package->name === $packageName && isset($package->source->reference)) { + } else if (isset($package->source->reference)) { $packageKey = $packageName . ':' . $package->source->reference; $cacheKey = self::CACHE_VERSION . ':' . $packageKey; // Check cache