icedream
/
php-language-server
1
0
Fork 0
Code Releases Activity

fix: We effectively don't need these tests 

They are tested as references to the TestClass
pull/679/head
Martin Letáček 2018-12-22 23:20:15 +01:00
parent 107c962df8
commit 89886b19e3
2 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Server/ServerTestCase.php
View File

@ -105,8 +105,6 @@ abstract class ServerTestCase extends TestCase
'TestNamespace\\TestClass::staticTestProperty' => new Location($symbolsUri, new Range(new Position(34, 18), new Position(34, 37))),
'TestNamespace\\TestClass::staticTestMethod()' => new Location($symbolsUri, new Range(new Position(46, 4), new Position(49, 5))),
'TestNamespace\\TestClass::testMethod()' => new Location($symbolsUri, new Range(new Position(57, 4), new Position(60, 5))),
'TestNamespace\\ChildClass::staticTestProperty'=> new Location($symbolsUri, new Range(new Position(34, 18), new Position(34, 37))),
'TestNamespace\\ChildClass::staticTestMethod()'=> new Location($symbolsUri, new Range(new Position(46, 4), new Position(49, 5))),
'TestNamespace\\test_function()' => new Location($symbolsUri, new Range(new Position(78, 0), new Position(81, 1))),
'TestNamespace\\whatever()' => new Location($referencesUri, new Range(new Position(21, 0), new Position(23, 1))),
'TestNamespace\\Example' => new Location($symbolsUri, new Range(new Position(101, 0), new Position(104, 1))),

24
tests/Server/TextDocument/References/GlobalTest.php
View File

@ -198,28 +198,4 @@ class GlobalTest extends ServerTestCase
)->wait();
$this->assertEquals([], $result);
}
public function testReferencesForInheritedStaticMethods()
{
// public static function staticTestMethod()
// Get references for staticTestMethod
$definition = $this->getDefinitionLocation('ChildClass::staticTestMethod()');
$result = $this->textDocument->references(
new ReferenceContext,
new TextDocumentIdentifier($definition->uri),
$definition->range->start
)->wait();
$this->assertEquals($this->getReferenceLocations('TestClass::staticTestMethod()'), $result);
}
public function testReferencesForInheritedStaticProperties()
{
// public static $staticTestProperty;
// Get references for $staticTestProperty
$definition = $this->getDefinitionLocation('ChildClass::staticTestProperty');
$result = $this->textDocument->references(
new ReferenceContext,
new TextDocumentIdentifier($definition->uri),
$definition->range->start
)->wait();
$this->assertEquals($this->getReferenceLocations('TestClass::staticTestProperty'), $result);
}
}