icedream
/
php-language-server
1
0
Fork 0
Code Releases Activity

Properly hiding when done with params

pull/250/head
Ivan Bozhanov 2017-01-20 17:44:25 +02:00
parent d433ae4ed0
commit 75e5e249da
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/SignatureHelpProvider.php
View File

@ -178,6 +178,9 @@ class SignatureHelpProvider
$stack = []; $stack = [];
while ($value !== "\0") { while ($value !== "\0") {
$lex->getNextToken($value); $lex->getNextToken($value);
if (($value === ")" || $value === ";") && !count($stack)) {
return $help;
}
if ($value === ',' && !count($stack)) { if ($value === ',' && !count($stack)) {
$help->activeParameter++; $help->activeParameter++;
} }
@ -191,7 +194,9 @@ class SignatureHelpProvider
} }
} catch (\Exception $ignore) { } } catch (\Exception $ignore) { }
} }
$help->signatures[] = $signature; if ($help->activeParameter < count($signature->parameters)) {
$help->signatures[] = $signature;
}
} }
return $help; return $help;