icedream
/
php-language-server
1
0
Fork 0
Code Releases Activity

Correct diagnostic behavior

pull/14/head
Felix Becker 2016-09-04 12:43:58 +02:00
parent 23f641f78b
commit 4e88a17de3
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Server/TextDocument.php
View File

@ -106,7 +106,7 @@ class TextDocument
$diagnostic = new Diagnostic(); $diagnostic = new Diagnostic();
$diagnostic->range = new Range( $diagnostic->range = new Range(
new Position($error->getStartLine() - 1, $error->hasColumnInfo() ? $error->getStartColumn($content) - 1 : 0), new Position($error->getStartLine() - 1, $error->hasColumnInfo() ? $error->getStartColumn($content) - 1 : 0),
new Position($error->getEndLine() - 1, $error->hasColumnInfo() ? $error->getEndColumn($content) - 1 : 0) new Position($error->getEndLine() - 1, $error->hasColumnInfo() ? $error->getEndColumn($content) : 0)
); );
$diagnostic->severity = DiagnosticSeverity::ERROR; $diagnostic->severity = DiagnosticSeverity::ERROR;
$diagnostic->source = 'php'; $diagnostic->source = 'php';
@ -114,9 +114,7 @@ class TextDocument
$diagnostic->message = $error->getRawMessage(); $diagnostic->message = $error->getRawMessage();
$diagnostics[] = $diagnostic; $diagnostics[] = $diagnostic;
} }
if (count($diagnostics) > 0) { $this->client->textDocument->publishDiagnostics($uri, $diagnostics);
$this->client->textDocument->publishDiagnostics($uri, $diagnostics);
}
// $stmts can be null in case of a fatal parsing error // $stmts can be null in case of a fatal parsing error
if ($stmts) { if ($stmts) {
$traverser = new NodeTraverser; $traverser = new NodeTraverser;