icedream
/
php-language-server
1
0
Fork 0
Code Releases Activity

Don't recheck condition

pull/357/head
Felix Becker 2017-06-09 20:00:21 +02:00
parent 4b573acde1
commit 4486ea0997
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/CompletionProvider.php
View File

@ -269,7 +269,8 @@ class CompletionProvider
$prefixWithNamespace = $namespacePrefix . "\\" . $prefix; $prefixWithNamespace = $namespacePrefix . "\\" . $prefix;
$fqnMatchesPrefixWithNamespace = substr($fqn, 0, strlen($prefixWithNamespace)) === $prefixWithNamespace; $fqnMatchesPrefixWithNamespace = substr($fqn, 0, strlen($prefixWithNamespace)) === $prefixWithNamespace;
$isFullyQualifiedAndPrefixMatches = !$isNotFullyQualified && ($fqnStartsWithPrefix || $fqnMatchesPrefixWithNamespace); $isFullyQualifiedAndPrefixMatches = !$isNotFullyQualified && ($fqnStartsWithPrefix || $fqnMatchesPrefixWithNamespace);
if (!$isFullyQualifiedAndPrefixMatches && !$isAliased && !array_search($fqn, array_values($namespaceImportTable))) { if (!$isFullyQualifiedAndPrefixMatches && !$isAliased) {
if (!array_search($fqn, array_values($namespaceImportTable))) {
if (empty($prefix)) { if (empty($prefix)) {
$fqn = '\\' . $fqn; $fqn = '\\' . $fqn;
} elseif ($fqnMatchesPrefixWithNamespace) { } elseif ($fqnMatchesPrefixWithNamespace) {
@ -277,9 +278,10 @@ class CompletionProvider
} else { } else {
continue; continue;
} }
} elseif (!$isFullyQualifiedAndPrefixMatches && !$isAliased) { } else {
continue; continue;
} }
}
} elseif ($fqnStartsWithPrefix && $class instanceof Node\QualifiedName && $class->isFullyQualifiedName()) { } elseif ($fqnStartsWithPrefix && $class instanceof Node\QualifiedName && $class->isFullyQualifiedName()) {
$fqn = '\\' . $fqn; $fqn = '\\' . $fqn;
} }