icedream
/
php-language-server
1
0
Fork 0
Code Releases Activity

fix(DefinitionResolver): fix crash on unknown foreach type (#562) 

Fix when unknown type is found in foreach expression
pull/564/head v5.3.1
Phil Nelson 2017-12-24 20:52:49 +11:00 committed by Felix Becker
parent a0caf8d18f
commit 425b2390b5
3 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fixtures/completion/foreach.php
View File

@ -35,3 +35,6 @@ foreach ($array3 as $key => $value) {
foreach ($bar->test() as $value) {
$
}
foreach ($unknownArray as $unknown) {
$unkno

1
src/DefinitionResolver.php
View File

@ -1122,6 +1122,7 @@ class DefinitionResolver
if ($collectionType instanceof Types\Array_) {
return $collectionType->getValueType();
}
return new Types\Mixed_();
}
// PROPERTIES, CONSTS, CLASS CONSTS, ASSIGNMENT EXPRESSIONS

15
tests/Server/TextDocument/CompletionTest.php
View File

@ -691,6 +691,21 @@ class CompletionTest extends TestCase
),
]
],
'foreach unknown type' => [
new Position(39, 10),
[
new CompletionItem(
'$unknown',
CompletionItemKind::VARIABLE,
'mixed',
null,
null,
null,
null,
new TextEdit(new Range(new Position(39, 10), new Position(39, 10)), 'wn')
),
]
],
];
}