diff --git a/README.md b/README.md
index fecd6c7..37800e0 100644
--- a/README.md
+++ b/README.md
@@ -180,7 +180,7 @@ Example:
- [VS Code PHP IntelliSense](https://github.com/felixfbecker/vscode-php-intellisense)
- [Eclipse Che](https://eclipse.org/che/)
- [Eclipse IDE (LSP4E-PHP)](https://github.com/eclipselabs/lsp4e-php)
- - [Neovim (nvim-cm-php-language-server)](https://github.com/roxma/nvim-cm-php-language-server)
+ - NeoVim: [LanguageServer-php-neovim](https://github.com/roxma/LanguageServer-php-neovim) with [LanguageClient neovim](https://github.com/autozimu/LanguageClient-neovim)
## Contributing
diff --git a/composer.json b/composer.json
index 6e8ae66..1f23bca 100644
--- a/composer.json
+++ b/composer.json
@@ -32,7 +32,7 @@
"phpdocumentor/reflection-docblock": "^3.0",
"sabre/event": "^5.0",
"felixfbecker/advanced-json-rpc": "^2.0",
- "squizlabs/php_codesniffer" : "^3.0",
+ "squizlabs/php_codesniffer" : "3.0.0RC3",
"netresearch/jsonmapper": "^1.0",
"webmozart/path-util": "^2.3",
"webmozart/glob": "^4.1",
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 4e3f6be..6cd8787 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -11,4 +11,7 @@
./src
+
+
+
diff --git a/src/DefinitionResolver.php b/src/DefinitionResolver.php
index ec295a5..7307de9 100644
--- a/src/DefinitionResolver.php
+++ b/src/DefinitionResolver.php
@@ -89,7 +89,14 @@ class DefinitionResolver
} else {
$docBlock = $node->getAttribute('docBlock');
if ($docBlock !== null) {
- return $docBlock->getSummary();
+ // check wether we have a description, when true, add a new paragraph
+ // with the description
+ $description = $docBlock->getDescription()->render();
+
+ if (empty($description)) {
+ return $docBlock->getSummary();
+ }
+ return $docBlock->getSummary() . "\n\n" . $description;
}
}
}
@@ -439,7 +446,7 @@ class DefinitionResolver
// Cannot get type for dynamic function call
return new Types\Mixed;
}
- $fqn = (string)($expr->getAttribute('namespacedName') ?? $expr->name);
+ $fqn = (string)($expr->getAttribute('namespacedName') ?? $expr->name) . '()';
$def = $this->index->getDefinition($fqn, true);
if ($def !== null) {
return $def->type;
diff --git a/src/LanguageServer.php b/src/LanguageServer.php
index 3c999f2..8fe9ec1 100644
--- a/src/LanguageServer.php
+++ b/src/LanguageServer.php
@@ -253,6 +253,7 @@ class LanguageServer extends AdvancedJsonRpc\Dispatcher
}
if ($this->workspace === null) {
$this->workspace = new Server\Workspace(
+ $this->client,
$this->projectIndex,
$dependenciesIndex,
$sourceIndex,
diff --git a/src/Protocol/FileEvent.php b/src/Protocol/FileEvent.php
index b4ed833..015044d 100644
--- a/src/Protocol/FileEvent.php
+++ b/src/Protocol/FileEvent.php
@@ -20,4 +20,14 @@ class FileEvent
* @var int
*/
public $type;
+
+ /**
+ * @param string $uri
+ * @param int $type
+ */
+ public function __construct(string $uri, int $type)
+ {
+ $this->uri = $uri;
+ $this->type = $type;
+ }
}
diff --git a/src/Server/Workspace.php b/src/Server/Workspace.php
index b94618c..d2f8cec 100644
--- a/src/Server/Workspace.php
+++ b/src/Server/Workspace.php
@@ -5,7 +5,15 @@ namespace LanguageServer\Server;
use LanguageServer\{LanguageClient, Project, PhpDocumentLoader};
use LanguageServer\Index\{ProjectIndex, DependenciesIndex, Index};
-use LanguageServer\Protocol\{SymbolInformation, SymbolDescriptor, ReferenceInformation, DependencyReference, Location};
+use LanguageServer\Protocol\{
+ FileChangeType,
+ FileEvent,
+ SymbolInformation,
+ SymbolDescriptor,
+ ReferenceInformation,
+ DependencyReference,
+ Location
+};
use Sabre\Event\Promise;
use function Sabre\Event\coroutine;
use function LanguageServer\{waitForEvent, getPackageName};
@@ -15,6 +23,11 @@ use function LanguageServer\{waitForEvent, getPackageName};
*/
class Workspace
{
+ /**
+ * @var LanguageClient
+ */
+ public $client;
+
/**
* The symbol index for the workspace
*
@@ -43,14 +56,16 @@ class Workspace
public $documentLoader;
/**
+ * @param LanguageClient $client LanguageClient instance used to signal updated results
* @param ProjectIndex $index Index that is searched on a workspace/symbol request
* @param DependenciesIndex $dependenciesIndex Index that is used on a workspace/xreferences request
* @param DependenciesIndex $sourceIndex Index that is used on a workspace/xreferences request
* @param \stdClass $composerLock The parsed composer.lock of the project, if any
* @param PhpDocumentLoader $documentLoader PhpDocumentLoader instance to load documents
*/
- public function __construct(ProjectIndex $index, DependenciesIndex $dependenciesIndex, Index $sourceIndex, \stdClass $composerLock = null, PhpDocumentLoader $documentLoader, \stdClass $composerJson = null)
+ public function __construct(LanguageClient $client, ProjectIndex $index, DependenciesIndex $dependenciesIndex, Index $sourceIndex, \stdClass $composerLock = null, PhpDocumentLoader $documentLoader, \stdClass $composerJson = null)
{
+ $this->client = $client;
$this->sourceIndex = $sourceIndex;
$this->index = $index;
$this->dependenciesIndex = $dependenciesIndex;
@@ -82,6 +97,21 @@ class Workspace
});
}
+ /**
+ * The watched files notification is sent from the client to the server when the client detects changes to files watched by the language client.
+ *
+ * @param FileEvent[] $changes
+ * @return void
+ */
+ public function didChangeWatchedFiles(array $changes)
+ {
+ foreach ($changes as $change) {
+ if ($change->type === FileChangeType::DELETED) {
+ $this->client->textDocument->publishDiagnostics($change->uri, []);
+ }
+ }
+ }
+
/**
* The workspace references request is sent from the client to the server to locate project-wide references to a symbol given its description / metadata.
*
diff --git a/tests/Server/ServerTestCase.php b/tests/Server/ServerTestCase.php
index fad2756..f5fec55 100644
--- a/tests/Server/ServerTestCase.php
+++ b/tests/Server/ServerTestCase.php
@@ -54,7 +54,7 @@ abstract class ServerTestCase extends TestCase
$client = new LanguageClient(new MockProtocolStream, new MockProtocolStream);
$this->documentLoader = new PhpDocumentLoader(new FileSystemContentRetriever, $projectIndex, $definitionResolver);
$this->textDocument = new Server\TextDocument($this->documentLoader, $definitionResolver, $client, $projectIndex);
- $this->workspace = new Server\Workspace($projectIndex, $dependenciesIndex, $sourceIndex, null, $this->documentLoader);
+ $this->workspace = new Server\Workspace($client, $projectIndex, $dependenciesIndex, $sourceIndex, null, $this->documentLoader);
$globalSymbolsUri = pathToUri(realpath(__DIR__ . '/../../fixtures/global_symbols.php'));
$globalReferencesUri = pathToUri(realpath(__DIR__ . '/../../fixtures/global_references.php'));
diff --git a/tests/Server/TextDocument/CompletionTest.php b/tests/Server/TextDocument/CompletionTest.php
index 39a3cee..29851e0 100644
--- a/tests/Server/TextDocument/CompletionTest.php
+++ b/tests/Server/TextDocument/CompletionTest.php
@@ -160,7 +160,12 @@ class CompletionTest extends TestCase
'TestClass',
CompletionItemKind::CLASS_,
null,
- 'Pariatur ut laborum tempor voluptate consequat ea deserunt.',
+ 'Pariatur ut laborum tempor voluptate consequat ea deserunt.' . "\n\n" .
+ 'Deserunt enim minim sunt sint ea nisi. Deserunt excepteur tempor id nostrud' . "\n" .
+ 'laboris commodo ad commodo velit mollit qui non officia id. Nulla duis veniam' . "\n" .
+ 'veniam officia deserunt et non dolore mollit ea quis eiusmod sit non. Occaecat' . "\n" .
+ 'consequat sunt culpa exercitation pariatur id reprehenderit nisi incididunt Lorem' . "\n" .
+ 'sint. Officia culpa pariatur laborum nostrud cupidatat consequat mollit.',
null,
null,
'\TestClass'
@@ -179,7 +184,12 @@ class CompletionTest extends TestCase
'TestClass',
CompletionItemKind::CLASS_,
'TestNamespace',
- 'Pariatur ut laborum tempor voluptate consequat ea deserunt.',
+ 'Pariatur ut laborum tempor voluptate consequat ea deserunt.' . "\n\n" .
+ 'Deserunt enim minim sunt sint ea nisi. Deserunt excepteur tempor id nostrud' . "\n" .
+ 'laboris commodo ad commodo velit mollit qui non officia id. Nulla duis veniam' . "\n" .
+ 'veniam officia deserunt et non dolore mollit ea quis eiusmod sit non. Occaecat' . "\n" .
+ 'consequat sunt culpa exercitation pariatur id reprehenderit nisi incididunt Lorem' . "\n" .
+ 'sint. Officia culpa pariatur laborum nostrud cupidatat consequat mollit.',
null,
null,
'TestClass'
@@ -218,7 +228,12 @@ class CompletionTest extends TestCase
'TestClass',
CompletionItemKind::CLASS_,
'TestNamespace',
- 'Pariatur ut laborum tempor voluptate consequat ea deserunt.'
+ 'Pariatur ut laborum tempor voluptate consequat ea deserunt.' . "\n\n" .
+ 'Deserunt enim minim sunt sint ea nisi. Deserunt excepteur tempor id nostrud' . "\n" .
+ 'laboris commodo ad commodo velit mollit qui non officia id. Nulla duis veniam' . "\n" .
+ 'veniam officia deserunt et non dolore mollit ea quis eiusmod sit non. Occaecat' . "\n" .
+ 'consequat sunt culpa exercitation pariatur id reprehenderit nisi incididunt Lorem' . "\n" .
+ 'sint. Officia culpa pariatur laborum nostrud cupidatat consequat mollit.'
)
], true), $items);
}
@@ -356,7 +371,12 @@ class CompletionTest extends TestCase
'TestClass',
CompletionItemKind::CLASS_,
null,
- 'Pariatur ut laborum tempor voluptate consequat ea deserunt.',
+ 'Pariatur ut laborum tempor voluptate consequat ea deserunt.' . "\n\n" .
+ 'Deserunt enim minim sunt sint ea nisi. Deserunt excepteur tempor id nostrud' . "\n" .
+ 'laboris commodo ad commodo velit mollit qui non officia id. Nulla duis veniam' . "\n" .
+ 'veniam officia deserunt et non dolore mollit ea quis eiusmod sit non. Occaecat' . "\n" .
+ 'consequat sunt culpa exercitation pariatur id reprehenderit nisi incididunt Lorem' . "\n" .
+ 'sint. Officia culpa pariatur laborum nostrud cupidatat consequat mollit.',
null,
null,
'TestClass'
diff --git a/tests/Server/TextDocument/HoverTest.php b/tests/Server/TextDocument/HoverTest.php
index 7d61354..cdc1718 100644
--- a/tests/Server/TextDocument/HoverTest.php
+++ b/tests/Server/TextDocument/HoverTest.php
@@ -22,7 +22,12 @@ class HoverTest extends ServerTestCase
)->wait();
$this->assertEquals(new Hover([
new MarkedString('php', "range), $result);
}
@@ -37,7 +42,12 @@ class HoverTest extends ServerTestCase
)->wait();
$this->assertEquals(new Hover([
new MarkedString('php', "range), $result);
}
@@ -181,7 +191,12 @@ class HoverTest extends ServerTestCase
$result = $this->textDocument->hover(new TextDocumentIdentifier($uri), new Position(59, 11))->wait();
$this->assertEquals(new Hover([
new MarkedString('php', "on('message', function (Message $message) use ($fileEvent, &$isDiagnosticsCleared) {
+ if ($message->body->method === "textDocument/publishDiagnostics") {
+ $this->assertEquals($message->body->params->uri, $fileEvent->uri);
+ $this->assertEquals($message->body->params->diagnostics, []);
+ $isDiagnosticsCleared = true;
+ }
+ });
+
+ $workspace->didChangeWatchedFiles([$fileEvent]);
+ Loop\tick(true);
+
+ $this->assertTrue($isDiagnosticsCleared, "Deleting file should clear all diagnostics.");
+ }
+}