From f16e4579cb35eadccb0cd100b2426e661ff8a875 Mon Sep 17 00:00:00 2001 From: Carl Kittelberger Date: Mon, 22 Jan 2024 00:26:55 +0100 Subject: [PATCH] Return 404 for empty database results. Without this special handling we return a 500 instead. --- icedreammusic/metacollector/cmd/metacollectord/main.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/icedreammusic/metacollector/cmd/metacollectord/main.go b/icedreammusic/metacollector/cmd/metacollectord/main.go index 4e1a6a0..2200d80 100644 --- a/icedreammusic/metacollector/cmd/metacollectord/main.go +++ b/icedreammusic/metacollector/cmd/metacollectord/main.go @@ -285,6 +285,10 @@ func main() { return } file, err := m.GetFile(uint(fileID)) + if errors.Is(err, gorm.ErrRecordNotFound) { + c.JSON(http.StatusNotFound, err.Error()) + return + } if err != nil { c.JSON(http.StatusInternalServerError, err.Error()) return @@ -310,6 +314,10 @@ func main() { return } track, err := m.GetTrackByArtistAndTitle(form.Artist, form.Title, false) + if errors.Is(err, gorm.ErrRecordNotFound) { + c.JSON(http.StatusNotFound, err.Error()) + return + } if err != nil { c.JSON(http.StatusInternalServerError, err.Error()) return